So I cast {golgari charm} to give everything -1 -1 until end of turn. Then I play {arbor elf}. Does my arbor elf die from golgari charm's effect? Or does it only effect creatures out when it's cast?
It only hits the creatures that are on the field when its cast. Your elf is safe!